Apply flexible types to files compiled without explicit nulls #23386
Conversation
|
Test performance please |
HarrisL2
force-pushed
the
flexibleunpickle
branch
from
a04a482 to
77c3c0c
Compare
|
[test_scala2_library_tasty] |
|
test performance please |
HarrisL2
force-pushed
the
flexibleunpickle
branch
from
77c3c0c to
a584b72
Compare
HarrisL2
force-pushed
the
flexibleunpickle
branch
from
a584b72 to
d9f49d1
Compare
| @@ -3424,6 +3428,15 @@ object Types extends TypeUtils { | |||
| // rule. | |||
| FlexibleType(OrNull(tp), tp) | |||
| } | |||
|
|
|||
| def make(tp: Type)(using Context): Type = | |||
There was a problem hiding this comment.
Do we really need a separate constructor for FlexibleType? I feel we can just merge this logic into apply.
| def apply(tp: Type)(using Context): FlexibleType = tp match { | ||
| def apply(tp: Type)(using Context): FlexibleType = | ||
| assert(tp.isValueType, s"Should not flexify ${tp}") | ||
| tp match { |
There was a problem hiding this comment.
Since we're now nullifying more complex types in Scala, do you think it's worth bringing the commented-out logic back?
| if outermostLevelAlreadyNullable then false | ||
| else tp match | ||
| case tp: TypeRef | ||
| if !ctx.flexibleTypes && tp.isRef(defn.RepeatedParamClass) => false | ||
| case _ => true | ||
|
|
||
| override def apply(tp: Type): Type = tp match { |
There was a problem hiding this comment.
We need to consider other cases now: ExprType, AnnotatedType, OrType , and MatchType (mayber? not sure).
| @@ -0,0 +1,21 @@ | |||
| package unsafeNulls | |||
|
|
|||
| class Unsafe_1 { | |||
There was a problem hiding this comment.
We need to test more scala tests.
A => B,=> TA { val b: B },A @Ba.type(A, B)A | B,A & B- ...
Also, let's test not only the functions, but also constructors, members (value and type), extension methods, etc.
| @@ -0,0 +1,18 @@ | |||
| byname-nullables.scala # identity() flexified | |||
There was a problem hiding this comment.
Can you choose some tests and explain them in the PR why they are excluded?
A fixed version of #22473
This PR wraps the types of symbols from files compiled without explicit nulls in flexible types.
This allows for interop between multiple files in cases where
compiled without explicit nulls can still be used in
whereas the argument would have been a strictly non-null String, because of the flexible type, the function call is now permitted.
[test_scala2_library_tasty]